uschindler commented on PR #13636: URL: https://github.com/apache/lucene/pull/13636#issuecomment-2271539092
Hi, your setup needs to be a bit different: - Don't invent new providers, use the existing one, so add a new factory method to the generic VectorizationProvider. Here you return a new implementation instance (like the existing one called VectorUtilSupport). If the implementation is a singleton, call the factory method `getVectorUtilSupport()`, if it creates a new one (with state, like ForUtil) call method `newForUtil()` - In src/main/java, you let the factory return the default instance - In src/main/javaXX you let it return the optimal instance I have another Draft PR: #12412 You can copy everything from there - yes I spent some work already on that! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
