mikemccand commented on PR #13525: URL: https://github.com/apache/lucene/pull/13525#issuecomment-2250217734
I think it's awesome to invest in our benchmarking tooling to be able to test different approaches for multi-valued vectors, but, I don't think that should be a blocker to merging this? It adds functionality over the block-join approach, and it's nice to have options for how to model multi-valued things. Block joins are powerful if you also have other attributes you'd like to query on at the child level, e.g. "KNN(query-vector) AND price < $50" joined up to parent documents ... but are maybe overkill if you really just want to have multiple vectors without such added per-vector constraints. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
