cpoerschke commented on code in PR #13525:
URL: https://github.com/apache/lucene/pull/13525#discussion_r1675739599


##########
lucene/core/src/java/org/apache/lucene/index/FieldInfos.java:
##########
@@ -452,7 +465,8 @@ synchronized int addOrGet(FieldInfo fi) {
                 new FieldVectorProperties(
                     fi.getVectorDimension(),
                     fi.getVectorEncoding(),
-                    fi.getVectorSimilarityFunction()));
+                    fi.getVectorSimilarityFunction()),
+                new 
FieldMultiVectorProperties(fi.getMultiVectorSimilarityFunction()));

Review Comment:
   Wondering if a separate `FieldMultiVectorProperties` is needed or if we 
could tack onto the `FieldVectorProperties` that is already there?
   ```suggestion
                       fi.getVectorSimilarityFunction(),
                       fi.getMultiVectorSimilarityFunction()));
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

Reply via email to