cpoerschke commented on code in PR #13525:
URL: https://github.com/apache/lucene/pull/13525#discussion_r1675737097


##########
lucene/core/src/java/org/apache/lucene/index/IndexingChain.java:
##########
@@ -1527,15 +1549,20 @@ void setPoints(int dimensionCount, int 
indexDimensionCount, int numBytes) {
     }
 
     void setVectors(
-        VectorEncoding encoding, VectorSimilarityFunction similarityFunction, 
int dimension) {
+        VectorEncoding encoding,
+        VectorSimilarityFunction similarityFunction,
+        int dimension,
+        MultiVectorSimilarityFunction.Aggregation multiVectorAggregate) {

Review Comment:
   added 
https://github.com/apache/lucene/pull/13525/commits/eacc63cb86f12a4087996c310a68ed3882d6f0f6
 to fold `setMultiVectors` into `setVectors` here



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

Reply via email to