ChrisHegarty commented on code in PR #13570:
URL: https://github.com/apache/lucene/pull/13570#discussion_r1683020894
##########
lucene/core/src/java/org/apache/lucene/index/IndexFileNames.java:
##########
@@ -142,6 +143,26 @@ public static String stripSegmentName(String filename) {
return filename;
}
+ /**
Review Comment:
> I'm not sure -- if you map the same file with the same Arena multiple
times, does the Arena itself do any deduplication? If one were to open a single
Arena, and then use that Arena to repeatedly map the same 2G file, would the
system eventually run out of virtual memory space?
Arena as an API can do quite a few of things, but the way we're using it in
Lucene is quite straightforward. In our usage it controls the lifetime of the
mmapped files, allowing for timely deallocation. We're not using it to do any
allocations directly, just associating the mappings to allow explicit release.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
