magibney commented on code in PR #13570:
URL: https://github.com/apache/lucene/pull/13570#discussion_r1683132959
##########
lucene/core/src/java/org/apache/lucene/index/IndexFileNames.java:
##########
@@ -142,6 +143,26 @@ public static String stripSegmentName(String filename) {
return filename;
}
+ /**
Review Comment:
> Why should we remap already open files multiple times? Lucene opens only
new segments, but old ones are kept open on index refreshes. We do not close or
reopen already open files.
I understand that this is how it should be, and why. I was asking to be
certain this wasn't a concern (esp. because the related expanded use of
`IOContext.READ_ONCE` and `Arena.ofConfined()` was addressing this exact
situation -- repeatedly re-opening files that had already been mapped). If this
is not a concern, that's great.
And separate Arenas per generation seems good too, I just wanted to raise
the possibility of multiple generations using the same arbitrarily-limited
Arena. Shouldn't be _necessary_, but I thought it might strike a useful balance
of further reducing `Arena.close()` while still providing "timely-enough"
de-allocation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
