benwtrent commented on PR #13546:
URL: https://github.com/apache/lucene/pull/13546#issuecomment-2218607252
@shubhamvishu stuff like this gets tricky when you see patterns like
`if(pendingNumDocs.incrementAndGet() > IndexWriter.getActualMaxDocs()) {`
There, you want to be ABSOLUTELY sure that you incremented and trip on a
get. This to me seems to make using LongAdder for something like
`pendingNumDocs` a bad idea.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
