original-brownbear commented on PR #13546: URL: https://github.com/apache/lucene/pull/13546#issuecomment-2211625398
The results are easily explained by the code change, the top methods in profiling go from: ``` 10.79% 129797 org.apache.lucene.facet.sortedset.SortedSetDocValuesFacetCounts#countOneSegmentNHLD() 5.81% 69901 org.apache.lucene.facet.taxonomy.FastTaxonomyFacetCounts#countAll() 4.60% 55316 org.apache.lucene.codecs.lucene90.Lucene90DocValuesProducer$25#advance() 4.35% 52334 org.apache.lucene.util.packed.DirectReader$DirectPackedReader20#get() 4.28% 51449 org.apache.lucene.search.TopScoreDocCollector$SimpleTopScoreDocCollector$1#collect() 3.74% 45035 org.apache.lucene.util.packed.DirectReader$DirectPackedReader12#get() 3.44% 41324 org.apache.lucene.search.TopFieldCollector$TopFieldLeafCollector#countHit() ``` to ``` 11.43% 131366 org.apache.lucene.facet.sortedset.SortedSetDocValuesFacetCounts#countOneSegmentNHLD() 6.19% 71133 org.apache.lucene.facet.taxonomy.FastTaxonomyFacetCounts#countAll() 4.88% 56035 org.apache.lucene.codecs.lucene90.Lucene90DocValuesProducer$25#advance() 4.48% 51495 org.apache.lucene.util.packed.DirectReader$DirectPackedReader20#get() 4.01% 46096 org.apache.lucene.util.packed.DirectReader$DirectPackedReader12#get() 3.30% 37975 jdk.internal.foreign.MemorySessionImpl#checkValidStateRaw() 3.15% 36257 org.apache.lucene.util.packed.DirectMonotonicReader#get() ``` with the top score collector moving way down to: ``` 0.93% 10727 org.apache.lucene.search.TopScoreDocCollector$SimpleTopScoreDocCollector$1#collect() ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
