original-brownbear commented on PR #13546: URL: https://github.com/apache/lucene/pull/13546#issuecomment-2218302360
@shubhamvishu what Ben says, plus keep in mind that the adder is less consistent and probably slower for <= 2 or 3 threads competing scenarios on x86 hardware (that seems to be what it comes down empirically today at least). This needs handling with care :) Also, the better solution (if possible) is generally to just not have the contention rather than implementing a better solution. I think this one in particular has an even stronger possible solution (it still shows up in profiling and it should no), looking into that once I find some time :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
