jimczi commented on PR #13288: URL: https://github.com/apache/lucene/pull/13288#issuecomment-2059552949
> I am not a huge fan of how every scorer can now just get a "queryOrdinal" and overwrite whatever query was passed to it. Yep that's tricky. I couldn't find a better way since my goal was to avoid having three level of vector scorers (FlatVectorScorer -> RandomVectorSupplier -> RandomVectorScorer). I'd still argue that this way of exposing things is more straightforward and allows to reduce the amount of code that relies on generic interface that needs to be casted. This `setQueryOrd` is only for the builder case though so completely internal and not something that the custom score should worry about (on how to use it). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
