benwtrent commented on PR #13288: URL: https://github.com/apache/lucene/pull/13288#issuecomment-2057715372
@jimczi OK, I read a bit more of your suggestion. I am not a huge fan of how every scorer can now just get a "queryOrdinal" and overwrite whatever query was passed to it. Some of the code reduction you did does seem nice, I am not sure I like the API however. I would need to fully flesh it out to see it in action. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
