benwtrent commented on code in PR #13288:
URL: https://github.com/apache/lucene/pull/13288#discussion_r1562457295
##########
lucene/codecs/src/java/org/apache/lucene/codecs/simpletext/SimpleTextKnnVectorsReader.java:
##########
@@ -472,9 +472,8 @@ private void readVector(byte[] value) throws IOException {
}
@Override
- public BytesRef vectorValue(int targetOrd) throws IOException {
- binaryValue.bytes = values[curOrd];
- return binaryValue;
+ public byte[] vectorValue(int targetOrd) throws IOException {
+ return values[curOrd];
Review Comment:
I actually don't think this reader needs to extend random access values at
all. I am going to try removing that extension.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
