benwtrent commented on PR #13288: URL: https://github.com/apache/lucene/pull/13288#issuecomment-2052087989
Hey @uschindler I didn't want to move forward on merging without your thoughts. This is a separate idea from: https://github.com/apache/lucene/pull/13200 This change is more inline to what we do with custom compression functions for other formats. It continues to rely on the reliance of "default formats", which is still an enumeration. However, this allows for a custom set of scorers be provided by a custom codec. The first example of this is the bit vector codec. While working on https://github.com/apache/lucene/pull/13200, it just kept looking more and more like a backwards compatibility nightmare and I just couldn't figure out a good interface with formats (like Scalar quantization) that need to know the exact similarity kind. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
