bugmakerrrrrr commented on PR #13235: URL: https://github.com/apache/lucene/pull/13235#issuecomment-2028716839
@benwtrent Sorry for being unresponsive. The code looks good to me. But I am wondering if we should move related check to the beginning of `rewrite` to make the knn query fail fast, as sometimes the filter query may be costly. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
