jpountz commented on code in PR #13235:
URL: https://github.com/apache/lucene/pull/13235#discussion_r1544585326


##########
lucene/join/src/java/org/apache/lucene/search/join/DiversifyingChildrenByteKnnVectorQuery.java:
##########
@@ -140,6 +140,10 @@ protected TopDocs approximateSearch(
     if (collector == null) {
       return NO_RESULTS;
     }
+    if (context.reader().getByteVectorValues(field) == null) {

Review Comment:
   I'm missing something: how would it differ from calling 
`ByteVectorValues.checkField(context.reader(), field);` without the enclosing 
`if` statement?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to