benwtrent commented on code in PR #13235:
URL: https://github.com/apache/lucene/pull/13235#discussion_r1544645006
##########
lucene/join/src/java/org/apache/lucene/search/join/DiversifyingChildrenByteKnnVectorQuery.java:
##########
@@ -140,6 +140,10 @@ protected TopDocs approximateSearch(
if (collector == null) {
return NO_RESULTS;
}
+ if (context.reader().getByteVectorValues(field) == null) {
Review Comment:
yeah, you are correct. I shouldn't even grab the vector values at all here,
just check the field.
For the other queries, it makes sense as we also use the vector values
later, but here we do not.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
