uschindler commented on code in PR #13142:
URL: https://github.com/apache/lucene/pull/13142#discussion_r1524661584
##########
lucene/core/src/java/org/apache/lucene/store/TrackingDirectoryWrapper.java:
##########
@@ -61,10 +61,8 @@ public void copyFrom(Directory from, String src, String
dest, IOContext context)
@Override
public void rename(String source, String dest) throws IOException {
in.rename(source, dest);
- synchronized (createdFileNames) {
- createdFileNames.add(dest);
- createdFileNames.remove(source);
- }
+ createdFileNames.add(dest);
+ createdFileNames.remove(source);
Review Comment:
I have the same problem. We need to avoid that. Unless there's an add+remove
atomic call to ConcurrentSet we need to synchronize.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
