mikemccand commented on code in PR #12900: URL: https://github.com/apache/lucene/pull/12900#discussion_r1423806163
########## lucene/core/src/java/org/apache/lucene/codecs/lucene90/blocktree/IntersectTermsEnum.java: ########## @@ -198,6 +204,7 @@ private IntersectTermsEnumFrame pushFrame(int state) throws IOException { } f.arc = arc; + f.outputPrefix = outputAccumulator.bytesRefs(); Review Comment: > I thought the `outputPrefix` will be always overwritten by `pushFrame` when we push into a new part of the FST. Did i miss something ? Ahh OK you are right -- and we could simply rewrite to empty `BytesRef` array which means the same thing as `null`. Good. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org