gf2121 commented on code in PR #12900:
URL: https://github.com/apache/lucene/pull/12900#discussion_r1423493276
##########
lucene/core/src/java/org/apache/lucene/codecs/lucene90/blocktree/IntersectTermsEnum.java:
##########
@@ -198,6 +204,7 @@ private IntersectTermsEnumFrame pushFrame(int state) throws
IOException {
}
f.arc = arc;
+ f.outputPrefix = outputAccumulator.bytesRefs();
Review Comment:
> Hmm shouldn't we sometimes set this outputPrefix back to null
We never set `outputPrefix` back to null. But a `BytesRef[0]` here is
equivalent, which means all prefix output (including current frame) are all
`NO_OUTPUT`.
> push into a new part of the FST that does not have an outputPrefix and
illegally share / use the old leftover stale outputPrefix?
I thought the `outputPrefix` will be always overwritten by `pushFrame` when
we push into a new part of the FST. Did i miss something ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
