gf2121 commented on code in PR #12900:
URL: https://github.com/apache/lucene/pull/12900#discussion_r1423704366
##########
lucene/core/src/java/org/apache/lucene/codecs/lucene90/blocktree/SegmentTermsEnum.java:
##########
@@ -495,7 +495,7 @@ public boolean seekExact(BytesRef target) throws
IOException {
targetUpto = 0;
outputAccumulator.push(arc.nextFinalOutput());
currentFrame = pushFrame(arc, 0);
- outputAccumulator.pop();
+ outputAccumulator.pop(arc.nextFinalOutput());
Review Comment:
This seems like another potential bug : If `arc.nextFinalOutput() ==
NO_OUTPUT`, we will not add the output into
the accumulator but we pop one out.
Not sure why we have not seen any bug report for this. Maybe our output
format protect it implicitly? This is in `SegmentTermsEnum` so it could
possibly affect merge. I'll dig to see if it is a real bug.
##########
lucene/core/src/java/org/apache/lucene/codecs/lucene90/blocktree/SegmentTermsEnum.java:
##########
@@ -495,7 +495,7 @@ public boolean seekExact(BytesRef target) throws
IOException {
targetUpto = 0;
outputAccumulator.push(arc.nextFinalOutput());
currentFrame = pushFrame(arc, 0);
- outputAccumulator.pop();
+ outputAccumulator.pop(arc.nextFinalOutput());
Review Comment:
This seems like another potential bug : If `arc.nextFinalOutput() ==
NO_OUTPUT`, we will not add the output into the accumulator but we pop one out.
Not sure why we have not seen any bug report for this. Maybe our output
format protect it implicitly? This is in `SegmentTermsEnum` so it could
possibly affect merge. I'll dig to see if it is a real bug.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
