gf2121 commented on code in PR #12900:
URL: https://github.com/apache/lucene/pull/12900#discussion_r1423505676
##########
lucene/core/src/java/org/apache/lucene/codecs/lucene90/blocktree/IntersectTermsEnumFrame.java:
##########
@@ -89,6 +89,9 @@ final class IntersectTermsEnumFrame {
final ByteArrayDataInput bytesReader = new ByteArrayDataInput();
+ // Cumulative outputs so far
+ BytesRef[] outputPrefix;
Review Comment:
> Wouldn't we be able to push/pop as we push/pop the frames, into the single
accumulator, so we don't need make extra arrays as we push deeper into the FST?
I'm not sure. Looking at `pushFrame`, it seems like one single frame could
be related to more than one `FST#Arc`. Maybe we need to record the number of
outputs pushed into the accumulator when pushing a frame ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
