gsmiller commented on PR #12837: URL: https://github.com/apache/lucene/pull/12837#issuecomment-1834309861
@slow-J oh sorry if I missed it. I didn't see it when I looked at the diff, but maybe I was looking at an old commit somehow. Dunno. Either way, it looks good to me! How would you like to handle the back port of this? We'll need to mark the public methods as deprecated on a 9.x release before we remove them on main. Normally, I'd just open a separate PR against 9x that marks deprecation and then remove them on main, but I'm not sure what we should do with some conversation starting about a 10.0 release. If we don't release a 9.10, then I _think_ we'll actually need to mark these public methods as deprecated in the 10.0 release and wait until an 11.0 release to actually remove them. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
