slow-J commented on PR #12837: URL: https://github.com/apache/lucene/pull/12837#issuecomment-1834496470
Since the ctors are used internally and I can't just mark them as deprecated with no changes: My plan for backport is: * Keep this PR against main as is. * Do another PR against 9_x for Lucene 9.10 with: * This entire change, but without removing any public APIs * This will also involve in 9_x only: duplicating the SortedSetDocValuesField#newSlowSetQuery SortedDocValuesField#newSlowSetQuery and KeywordField#newSetQuery methods so that the new ones take collections and marking the old ones that take varargs as deprecated. * Mark the TermInSetQuery ctors with varargs as deprecated. How does this sound @gsmiller ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org