rmuir commented on PR #12753: URL: https://github.com/apache/lucene/pull/12753#issuecomment-1792821264
ok, i think the best fix is to just cutover this benchmark task to take a tag. The parsing is strict, so if someone has .alg file with `en,US` or whatever, they will get a nice error message and just need to change to tag (e.g. `en-US`): ``` > java.util.IllformedLocaleException: Invalid subtag: en,US [at index 0] > at __randomizedtesting.SeedInfo.seed([93469BC41AA902E:8C022240A6E1B490]:0) > at java.base/java.util.Locale$Builder.setLanguageTag(Locale.java:2749) > at org.apache.lucene.benchmark.byTask.tasks.NewLocaleTask.createLocale(NewLocaleTask.java:53) ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org