ChrisHegarty commented on code in PR #12753:
URL: https://github.com/apache/lucene/pull/12753#discussion_r1382022708
##########
lucene/benchmark/src/test/org/apache/lucene/benchmark/byTask/TestPerfTasksLogic.java:
##########
@@ -793,19 +793,17 @@ public void testLocale() throws Exception {
// ROOT locale
benchmark = execBenchmark(getLocaleConfig("ROOT"));
- assertEquals(new Locale(""), benchmark.getRunData().getLocale());
+ assertEquals(Locale.ROOT, benchmark.getRunData().getLocale());
// specify just a language
benchmark = execBenchmark(getLocaleConfig("de"));
- assertEquals(new Locale("de"), benchmark.getRunData().getLocale());
+ assertEquals(
+ new Locale.Builder().setLanguageTag("de").build(),
benchmark.getRunData().getLocale());
Review Comment:
Trivially we could use `Locale.GERMAN`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
