rmuir commented on PR #12753: URL: https://github.com/apache/lucene/pull/12753#issuecomment-1792687728
the only ugly one was the benchmark locale task, because its got a method shaped just like the deprecated java-ism: ``` static Locale createLocale(String language, String country, String variant) ``` If we want to make it prettier, the fix to that is to change signature of `createLocale` (separate issue) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
