rmuir commented on code in PR #12753:
URL: https://github.com/apache/lucene/pull/12753#discussion_r1382155265
##########
lucene/analysis/common/src/java/org/apache/lucene/analysis/de/GermanStemmer.java:
##########
@@ -33,7 +33,7 @@ class GermanStemmer {
/** Amount of characters that are removed with <code>substitute()</code>
while stemming. */
private int substCount = 0;
- private static final Locale locale = new Locale("de", "DE");
+ private static final Locale locale = new
Locale.Builder().setLanguageTag("de-DE").build();
Review Comment:
i should explain: it is just some paranoia on my side. a lot of the
associated tech here tries to provide stable standards, but they aren't in
control. you see crazy shit go down in this CLDR data or other associated
events (e.g. "emergency" unicode releases and stuff) all because some country
decided they need a new symbol (e.g. ₹), or that a timezone should work
differently.
##########
lucene/analysis/common/src/java/org/apache/lucene/analysis/de/GermanStemmer.java:
##########
@@ -33,7 +33,7 @@ class GermanStemmer {
/** Amount of characters that are removed with <code>substitute()</code>
while stemming. */
private int substCount = 0;
- private static final Locale locale = new Locale("de", "DE");
+ private static final Locale locale = new
Locale.Builder().setLanguageTag("de-DE").build();
Review Comment:
i should explain: it is just some paranoia on my side. a lot of the
associated tech here tries to provide stable standards, but they aren't in
control. you see crazy shit go down in this CLDR data or other associated
events (e.g. "emergency" unicode releases and stuff) all because some country
decided they need a new symbol (e.g. ₹), or that a timezone should work
differently.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
