luyuncheng commented on code in PR #12723: URL: https://github.com/apache/lucene/pull/12723#discussion_r1374824046
########## lucene/core/src/java/org/apache/lucene/util/bkd/BKDReader.java: ########## @@ -216,7 +216,7 @@ private static class BKDPointTree implements PointTree { scratchMinIndexPackedValue, scratchMaxIndexPackedValue; private final int[] commonPrefixLengths; - private final BKDReaderDocIDSetIterator scratchIterator; + private final BKDReaderDocIDSet scratch; Review Comment: `BKDReaderDocIDSetIterator` using int array to do DocIdSetIterator. But i want to use `DocBaseBitSetIterator` to reduce iterator and optimize `visit(DocIdSetIterator iterator)`. AND also in type `DELTA_BPV_16` using int array to do iterator without renew int array. so i rename BKDReaderDocIDSetIterator to BKDReaderDocIDSet which usage is not a iterator. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org