luyuncheng commented on code in PR #12723:
URL: https://github.com/apache/lucene/pull/12723#discussion_r1374132105
##########
lucene/core/src/java/org/apache/lucene/util/DocBaseBitSetIterator.java:
##########
@@ -69,6 +69,9 @@ public int getDocBase() {
@Override
public int nextDoc() {
+ if (doc == NO_MORE_DOCS) {
Review Comment:
For `gradlew test --tests TestBKD.testAllEqual` -> verify
it use
https://github.com/apache/lucene/blob/09da2291c501e25c38a2cb69899b69afb65a22e5/lucene/core/src/test/org/apache/lucene/util/bkd/TestBKD.java#L995-L1013
to check the DocIdSetIterator.
and When L1004 iteration ends with `NO_MORE_DOCS`, but L1011 do again
##########
lucene/core/src/java/org/apache/lucene/util/DocBaseBitSetIterator.java:
##########
@@ -69,6 +69,9 @@ public int getDocBase() {
@Override
public int nextDoc() {
+ if (doc == NO_MORE_DOCS) {
Review Comment:
@gf2121 For `gradlew test --tests TestBKD.testAllEqual` -> verify
it use
https://github.com/apache/lucene/blob/09da2291c501e25c38a2cb69899b69afb65a22e5/lucene/core/src/test/org/apache/lucene/util/bkd/TestBKD.java#L995-L1013
to check the DocIdSetIterator.
and When L1004 iteration ends with `NO_MORE_DOCS`, but L1011 do again
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
