msokolov commented on code in PR #12723:
URL: https://github.com/apache/lucene/pull/12723#discussion_r1374646933
##########
lucene/core/src/java/org/apache/lucene/util/bkd/BKDReader.java:
##########
@@ -216,7 +216,7 @@ private static class BKDPointTree implements PointTree {
scratchMinIndexPackedValue,
scratchMaxIndexPackedValue;
private final int[] commonPrefixLengths;
- private final BKDReaderDocIDSetIterator scratchIterator;
+ private final BKDReaderDocIDSet scratch;
Review Comment:
Please don't rename this - it makes it more difficult to read the PR and
find your significant contribution amidst what looks like noise. It's confusing
that in some places you renamed it to `scratch` and in other places to
`iterator` -- is there some difference?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
