zhaih commented on PR #12660: URL: https://github.com/apache/lucene/pull/12660#issuecomment-1760280351
That sounds great, thanks Mike! Please post the PR and I will try to see how to put it together. Meanwhile let's try to get the prerequisite PR reviewed and pushed first? Such that this one can look cleaner. On Thu, Oct 12, 2023, 11:07 Michael Sokolov ***@***.***> wrote: > This looks like a great start. I worked up a very similar PR but I think I > have some concurrency bugs around the update/add of new entry points in the > upper graph levels. I might post mine anyway because it has some syntax > sugar I think would be nice to bring over here. One idea I had was to > create a NeighborArrayIterator that would handle read-locking in the > OnHeapGraph case with another implementation that just encapsulates the > iteration with no locking for use by other (off-heap) HnswGraph. With that > and a little refactoring we can use the same HnswGraphSearcher for both > cases? > > — > Reply to this email directly, view it on GitHub > <https://github.com/apache/lucene/pull/12660#issuecomment-1760118913>, or > unsubscribe > <https://github.com/notifications/unsubscribe-auth/AEFSB7C4JF6SQ7JQ2SJCR63X7AWVFANCNFSM6AAAAAA55CGFD4> > . > You are receiving this because you authored the thread.Message ID: > ***@***.***> > -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
