zhaih commented on PR #12660: URL: https://github.com/apache/lucene/pull/12660#issuecomment-1772185807
@msokolov I incorporate your change about passing in the executor and addVector from range. I also added the wire up to passing in parameters from VectorFormat all the way in. For the NeighbourIterator I still need to think a bit, the part I'm a little bit unsure is that if we keep the reader lock locked and just pass an iterator out (without copy the array) it may create more contention. So that part I'm still keeping my original implementation. Anyway I think right now all the prerequisite PRs is checked in so it's in a reviewable state. Altho I still need to add javadocs, tests I still want some early feedback on the class struture, interface and logic improvement. So please review it! cc. @benwtrent thanks for creating the merger abstraction, I used it right away, so if you have some spare time please review it as well! I added some more details to the description you may want to check before reading the code. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
