msokolov commented on PR #12660: URL: https://github.com/apache/lucene/pull/12660#issuecomment-1760118913
This looks like a great start. I worked up a very similar PR but I think I have some concurrency bugs around the update/add of new entry points in the upper graph levels. I might post mine anyway because it has some syntax sugar I think would be nice to bring over here. One idea I had was to create a NeighborArrayIterator that would handle read-locking in the OnHeapGraph case with another implementation that just encapsulates the iteration with no locking for use by other (off-heap) HnswGraph. With that and a little refactoring we can use the same HnswGraphSearcher for both cases? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
