benwtrent commented on PR #12636: URL: https://github.com/apache/lucene/pull/12636#issuecomment-1760104677
> Which interface are you referring to ....RandomAccessVectorValues? as that uses generics to avoid duplication? During the refactoring for byte/float I did a while back, during refactoring, one of the iterations I had used an interface similar to the one you have made here. It was shot down as it was unnecessarily complex without much gain. I am inclined to agree. It doesn't gain us much. I would rather a little code duplication than a bad abstraction. > You mean we could do something similar to RandomVectorScorer etc. what has been done for RandomAccessVectorValues(i.e. use generics)? I think there are places where we duplicate code unnecessarily because we are not using scorers, but instead creating a vector reader & scorer separately. > So are you suggesting saying instead of making [Float/Byte]VectorValues use this VectorValues interface we should only try avoiding duplication at the places you pointed? I think so. I don't want us adding an abstraction we are not 100% sure of for very little gain. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
