shubhamvishu opened a new pull request, #12636: URL: https://github.com/apache/lucene/pull/12636
### Description The classes [ByteVectorValues](https://github.com/apache/lucene/blob/main/lucene/core/src/java/org/apache/lucene/index/ByteVectorValues.java) and [FloatVectorValues](https://github.com/apache/lucene/blob/main/lucene/core/src/java/org/apache/lucene/index/FloatVectorValues.java) share the common functionalities/methods listed below. This PR moves those methods to a new interface `VectorValues`. - int dimension() - int size() - byte[]/float[] vectorValue() Since the name is clashing, created two new names `vectorByteValue` and `vectorFloatValue`. Also retained the `vectorValue` method whose returned value needs to be casted appropriately. There could be some other ideas as well like 1. Making `DISI` implementing an interface which `VectorValues`(in this PR) would extend making further room to remove duplication (or) 2. Making a wrapper over `ByteVectorValues` and `FloatVectorValues` etc?. Looking for more ideas or suggestions on how to better handle this and avoid duplicating code. Addresses #12635 <!-- If this is your first contribution to Lucene, please make sure you have reviewed the contribution guide. https://github.com/apache/lucene/blob/main/CONTRIBUTING.md --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
