benwtrent commented on PR #12636: URL: https://github.com/apache/lucene/pull/12636#issuecomment-1752194821
It was sort of this way before but we decided to switch it as a common interface required either: - having to use generics - an API where things weren't fully implemented or required casting. If we are worried about internal duplication there may be better options around using a better abstraction for scoring (see RandomVectorScorer) and writing to a flat file (on flush and merges). Those are the only two places we care about reading vectors during indexing and search. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
