shubhamvishu commented on PR #12636: URL: https://github.com/apache/lucene/pull/12636#issuecomment-1759814356
@benwtrent Do you mean we earlier had similar implementation or such interface? > we decided to switch it as a common interface required either Which interface are you referring to ....`RandomAccessVectorValues`? as that uses generics to avoid duplication? >If we are worried about internal duplication there may be better options around using a better abstraction for scoring (see RandomVectorScorer) and writing to a flat file (on flush and merges) You mean we could do something similar to `RandomVectorScorer` etc. what has been done for `RandomAccessVectorValues`(i.e. use generics)? So are you suggesting saying instead of making `[Float/Byte]VectorValues` use this `VectorValues` interface we should only try avoiding duplication at the places you pointed? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
