uschindler commented on PR #12376: URL: https://github.com/apache/lucene/pull/12376#issuecomment-1593732104
> This is just a very basic sanity of the code, which I think is fine. I’d find it useful to have this if modifying the code locally. The CI, etc should already be testing this more extensively. Thanks. The main idea of this test is: - make sure the code actuall links and works with JDK 20/21 API (as we only compile against stubs). - make sure the code behaves identical to the scalar impl (I trust Roberts code, but what happens if somebody changes a variable name in the code). In addition this improves test coverage... We do not want to test Panama Vector nor Hotspot here! > Separately, how much time is disabling C2 saving when running unit tests? We had several discussions, but it was dramatical for tests. For the short living execs during build (like javac, javadoc, ecj) we have: #10900; for tests we had a separate issue, not sure which one. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
