uschindler commented on code in PR #12376: URL: https://github.com/apache/lucene/pull/12376#discussion_r1231283028
########## lucene/core/src/java20/org/apache/lucene/util/VectorUtilPanamaProvider.java: ########## @@ -295,7 +301,7 @@ public int dotProduct(byte[] a, byte[] b) { int res = 0; // only vectorize if we'll at least enter the loop a single time, and we have at least 128-bit // vectors (256-bit on intel to dodge performance landmines) - if (a.length >= 16 && IS_AMD64_WITHOUT_AVX2 == false) { + if (a.length >= 16 && hasFastIntegerVectors) { Review Comment: Actually I like this more, because it is no negative test. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org