uschindler commented on code in PR #12376:
URL: https://github.com/apache/lucene/pull/12376#discussion_r1231281792


##########
lucene/core/src/test/org/apache/lucene/util/TestVectorUtilProviders.java:
##########
@@ -27,7 +27,7 @@ public class TestVectorUtilProviders extends LuceneTestCase {
 
   private static final double DELTA = 1e-3;
   private static final VectorUtilProvider LUCENE_PROVIDER = new 
VectorUtilDefaultProvider();
-  private static final VectorUtilProvider JDK_PROVIDER = VectorUtil.PROVIDER;
+  private static final VectorUtilProvider JDK_PROVIDER = 
VectorUtilProvider.lookup(true);

Review Comment:
   This test only compares the default lucene provider with a few random 
vectors and compares results. So slowness does not matter here!
   
   Of course here we only test the Panama Implementation if it is Java 20/21 
and it is not buggy (turkish locale bug).



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

Reply via email to