dsmiley commented on PR #12306: URL: https://github.com/apache/lucene/pull/12306#issuecomment-1553035652
There are non-mutually exclusive things that could happen to help a user wanting to work with higher dimensions; this PR focuses on **configurability** of an implementation that **already exists**. If this PR were to become non-veto worthy to others somehow, I see it needs to be a _supported_ number of dimensions, not merely any number a user might set it to (even though IMO that'd be fine). Thanks for the tip Uwe RE MMapDirectory. > Just to make sure I understand the -1 correctly: The concern is that if a user can set the dimension by himself, because the Lucene version works well with this dimension at that time for this user, but let's assume that a future Lucene version will not work anymore or not work well enough anymore with the dimension set by the user, then this means the user cannot use this new Lucene version in the future. Is this the main concern? This is addressable by actually setting it to 2048 in tests to show that we support it, even though its default value should be what it is now. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
