alessandrobenedetti commented on PR #12306: URL: https://github.com/apache/lucene/pull/12306#issuecomment-1553641166
I mean, yeah, I hate limits that are not related to typing constraint, and also in that case, I agree they are magic numbers behind the scenes :) Still, I would question why showing a warning for 2049 and not for 2047. To be honest I don't have a better option, except maybe "no warning at all". Anyway It's not something I would enforce it as a veto as long as someone can go upper than 2048 with no consequence except the warning -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
