dsmiley commented on PR #12306: URL: https://github.com/apache/lucene/pull/12306#issuecomment-1552322741
The only argument you've given against a system property specifically is: > system property is not used appropriately (e.g. proper security checks). If there is a security manager, and it doesn't allow read to this property, classes will fail to load. Okay, good point. I can improve the PR to catch a SecurityException and use the default value; maybe log a warning as well. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
