gsmiller commented on PR #12055: URL: https://github.com/apache/lucene/pull/12055#issuecomment-1435469343
@rmuir thanks for the feedback. Let me see if I can respond to all of it here: > postings reuse problems Can you help me with where you see this as a problem? I went through the code and didn't see any obvious mistakes. I'm sure I'm missing it? The only tricky one is in the do/while loop in MTQCSW starting on line 214. But I think this is safe since we reassign `postings` to `dropped` at the end of the loop, so `postings` should be safe to reuse at that point. Again, not trying to challenge this feedback, just trying to understand what I'm overlooking. > objection to modifying MTQCSW rewrite in general / learn from "constant score auto rewrite" history Thanks for raising this. I wasn't aware of the history here so I'll have to go do some digging. I'll take that on as a next step. > have TermInSetQuery extend MultiTermQuery I'd looked at this in the past and had found performance regressions with this approach, which I believe were caused by the different term intersection approach (seekCeil vs. seekExact). I don't recall the amount of regression though. I'll see if I can dig that up. Hopefully I documented it somewhere. But if not, I'll try to re-benchmark. Maybe the regressions don't justify the separate implementation. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
