rmuir commented on PR #12055: URL: https://github.com/apache/lucene/pull/12055#issuecomment-1435401885
I dont see any of my feedback addressed. I'll repeat what i said before: * We shouldn't be forming booleanqueries from a `FILTER` rewrite, this is wrong to do and it causes some slowdowns in some cases. We need more rewrites instead of one 'wonder-do-it-all'. * We are still reusing postingsenum (now only some of the time, grr) and tossing them into priority queues. this is unsafe. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
