gsmiller commented on code in PR #12055:
URL: https://github.com/apache/lucene/pull/12055#discussion_r1119345563
##########
lucene/core/src/java/org/apache/lucene/search/DisiWrapper.java:
##########
@@ -57,4 +56,13 @@ public DisiWrapper(Scorer scorer) {
matchCost = 0f;
}
}
+
+ public DisiWrapper(DocIdSetIterator iterator) {
+ this.scorer = null;
+ this.iterator = iterator;
+ this.cost = iterator.cost();
+ this.twoPhaseView = null;
+ this.approximation = iterator;
+ this.matchCost = 0;
+ }
Review Comment:
Yeah, that's reasonable I think. We'd be doing a little unnecessary object
creation with the "dummy" scorer wrapper, but that's alright. I'll work this
suggestion in. Honestly, I'm not super happy with either option, but I think
this is a good suggestion for now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
