gsmiller commented on code in PR #11901: URL: https://github.com/apache/lucene/pull/11901#discussion_r1044901068
########## lucene/facet/src/java/org/apache/lucene/facet/rangeonrange/Range.java: ########## @@ -0,0 +1,52 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.lucene.facet.rangeonrange; + +import java.util.Arrays; + +/** + * Base class for a single labeled range. + * + * @lucene.experimental + */ +public abstract class Range { + + /** Label that identifies this range. */ + public final String label; + + /** Number of dims per range */ + public final int dims; + + /** Sole constructor. */ + protected Range(String label, int dims) { + if (label == null) { + throw new NullPointerException("label must not be null"); + } + this.label = label; + this.dims = dims; + } + + /** Invoke this for a useless range. */ + protected void failNoMatch() { + throw new IllegalArgumentException("range \"" + label + "\" matches nothing"); + } + + /** Gets a corresponding array of labels given a range */ + public static String[] getLabelsFromRanges(Range[] ranges) { Review Comment: Can this be pkg-private? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
