gsmiller commented on code in PR #11901:
URL: https://github.com/apache/lucene/pull/11901#discussion_r1044897144


##########
lucene/core/src/java/org/apache/lucene/document/LongRangeDocValuesField.java:
##########
@@ -86,4 +87,28 @@ private static void checkArgs(final long[] min, final long[] 
max) {
       }
     }
   }
+
+  /**
+   * Sets the value of this field to a new value
+   *
+   * @param min the new min
+   * @param max the new max
+   */
+  public void setLongRangeValue(long min, long max) {

Review Comment:
   Right, but they're optional for fields (and not required for users or 
tests). Have a look at the javadoc for `Field#setStringValue`. I think it will 
make it a bit more clear. For your unit tests specifically, you can just create 
new field instances right?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

Reply via email to