gsmiller commented on code in PR #11901: URL: https://github.com/apache/lucene/pull/11901#discussion_r1046413930
########## lucene/facet/src/java/org/apache/lucene/facet/rangeonrange/DoubleRangeOnRangeFacetCounts.java: ########## @@ -0,0 +1,94 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.lucene.facet.rangeonrange; + +import static org.apache.lucene.document.DoubleRange.verifyAndEncode; + +import java.io.IOException; +import org.apache.lucene.document.RangeFieldQuery; +import org.apache.lucene.facet.FacetsCollector; +import org.apache.lucene.search.Query; + +/** + * Represents counts for double range on range faceting. To be more specific, this means that given + * a range (or list of ranges), this class will count all the documents in the index (or that match + * a fast match query) that contain ranges that "match" the provided ranges. These ranges are + * specified by the field parameter and expected to be of type {@link + * org.apache.lucene.document.DoubleRangeDocValuesField}. Matching is defined by the queryType + * param, you can see the type of matching supported by looking at {@link + * org.apache.lucene.document.RangeFieldQuery.QueryType}. In addition, this class supports + * multidimensional ranges. A multidimensional range will be counted as a match if every dimension + * matches the corresponding indexed range's dimension. + */ +public class DoubleRangeOnRangeFacetCounts extends RangeOnRangeFacetCounts { + + /** + * Constructor without the fast match query, see other constructor description for more details. + */ + public DoubleRangeOnRangeFacetCounts( + String field, + FacetsCollector hits, + RangeFieldQuery.QueryType queryType, + DoubleRange... ranges) + throws IOException { + super( + field, + hits, + queryType, + null, + Double.BYTES, + getEncodedRanges(ranges), + Range.getLabelsFromRanges(ranges)); + } + + /** + * Represents counts for long range on range faceting. See class javadoc for more details. + * + * @param field specifies a {@link org.apache.lucene.document.LongRangeDocValuesField} that will Review Comment: Should be DoubleRangeDocValuesField right? ########## lucene/facet/src/java/org/apache/lucene/facet/rangeonrange/DoubleRangeOnRangeFacetCounts.java: ########## @@ -0,0 +1,94 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.lucene.facet.rangeonrange; + +import static org.apache.lucene.document.DoubleRange.verifyAndEncode; + +import java.io.IOException; +import org.apache.lucene.document.RangeFieldQuery; +import org.apache.lucene.facet.FacetsCollector; +import org.apache.lucene.search.Query; + +/** + * Represents counts for double range on range faceting. To be more specific, this means that given + * a range (or list of ranges), this class will count all the documents in the index (or that match + * a fast match query) that contain ranges that "match" the provided ranges. These ranges are + * specified by the field parameter and expected to be of type {@link + * org.apache.lucene.document.DoubleRangeDocValuesField}. Matching is defined by the queryType + * param, you can see the type of matching supported by looking at {@link + * org.apache.lucene.document.RangeFieldQuery.QueryType}. In addition, this class supports + * multidimensional ranges. A multidimensional range will be counted as a match if every dimension + * matches the corresponding indexed range's dimension. + */ +public class DoubleRangeOnRangeFacetCounts extends RangeOnRangeFacetCounts { + + /** + * Constructor without the fast match query, see other constructor description for more details. + */ + public DoubleRangeOnRangeFacetCounts( + String field, + FacetsCollector hits, + RangeFieldQuery.QueryType queryType, + DoubleRange... ranges) + throws IOException { + super( + field, + hits, + queryType, + null, + Double.BYTES, + getEncodedRanges(ranges), + Range.getLabelsFromRanges(ranges)); + } + + /** + * Represents counts for long range on range faceting. See class javadoc for more details. Review Comment: I think you mean to say "double" here instead of "long" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
