gsmiller commented on code in PR #11901: URL: https://github.com/apache/lucene/pull/11901#discussion_r1044900429
########## lucene/facet/src/java/org/apache/lucene/facet/rangeonrange/LongRange.java: ########## @@ -0,0 +1,124 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.lucene.facet.rangeonrange; + +import java.util.Arrays; +import java.util.Objects; + +/** Represents a long range for RangeOnRange faceting */ +public class LongRange extends Range { + /** Minimum (inclusive). */ + public final long[] min; + + /** Maximum (inclusive). */ + public final long[] max; + + /** + * Represents a single dimensional long range for RangeOnRange faceting + * + * @param label the name of the range + * @param minIn the minimum + * @param minInclusive if the minimum is inclusive + * @param maxIn the maximum + * @param maxInclusive if the maximum is inclusive + */ + public LongRange( + String label, long minIn, boolean minInclusive, long maxIn, boolean maxInclusive) { + super(label, 1); + + if (!minInclusive) { Review Comment: Hmm, yeah that's fair. OK, I think what you've got is fine then. I did just notice you're using `!` though instead of `== false` in those ctors. Mind changing that? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
